Skip to content

Update to rail v2.0: Parameter changes, ephemeral DataStore and interactive package#244

Merged
jscora merged 200 commits into
LSSTDESC:mainfrom
sidratresearch:sidrat-staging
Feb 18, 2026
Merged

Update to rail v2.0: Parameter changes, ephemeral DataStore and interactive package#244
jscora merged 200 commits into
LSSTDESC:mainfrom
sidratresearch:sidrat-staging

Conversation

@jscora
Copy link
Copy Markdown
Contributor

@jscora jscora commented Dec 19, 2025

Problem & Solution Description (including issue #)

This PR involves the following changes:

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

jscora and others added 30 commits October 27, 2025 14:46
…_do_chunk_output` in CatEstimator into two separate functions
…tor and minor fixes for _update_ancil and _handle_chunk_output
Future work to come for specific tooling - usage will look something
like `numpydoc validate
rail.estimation.algos.random_gauss.RandomGaussEstimator.estimate` where
this points to a specific entrypoint function
Stubs paths aren't quite right I think
Stub files are copy/pasted and then have additional formatting and
typing is imported
@jscora jscora mentioned this pull request Jan 26, 2026
18 tasks
Copy link
Copy Markdown
Collaborator

@eacharles eacharles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering a bit about the process you envisage for keeping the .pyi files up to data.

Thanks for all the very nice work.

@jscora
Copy link
Copy Markdown
Contributor Author

jscora commented Feb 5, 2026

I'm wondering a bit about the process you envisage for keeping the .pyi files up to data.

Thanks for all the very nice work.

That's a good question -- we can go over it a bit in the meeting on Monday, but our current thought is to add a test to the smoke tests that checks if the .pyi files need to be updated, and then will output the appropriate error message so it will be obvious that what needs to happen is a quick PR where you just run the script to create the .pyi files again.

- removes the `input` kwarg that was sometimes a dict, all params are
now called by their original names
- reads the ceci input handles of stages, and ensures those are captured
in docstrings and required kwargs of interactive functions

- many knock-on effects of those two things
@jscora jscora merged commit 5c4f576 into LSSTDESC:main Feb 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants