Skip to content

railv2-bug-fixes#247

Merged
jscora merged 27 commits into
mainfrom
jscora/railv2-bug-fixes
Feb 26, 2026
Merged

railv2-bug-fixes#247
jscora merged 27 commits into
mainfrom
jscora/railv2-bug-fixes

Conversation

@jscora

@jscora jscora commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

Problem & Solution Description (including issue #)

  • Removes test_creator (added in v2.0 PR) which failed because it required pzflow
  • replaces np.in1d with np.isin and np.trapz with np.trapezoid because they've been deprecated
  • adds workflow to run create_interactive_structure script
  • smoke tests now post results to the rail slack channel

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

@codecov

codecov Bot commented Feb 19, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 32.00000% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.89%. Comparing base (9596d74) to head (0a30fe0).
⚠️ Report is 229 commits behind head on main.

Files with missing lines Patch % Lines
src/rail/utils/interactive/docstring_utils.py 27.27% 16 Missing ⚠️
src/rail/utils/interactive/initialize_utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
- Coverage   99.86%   93.89%   -5.97%     
==========================================
  Files          54       67      +13     
  Lines        3746     4342     +596     
==========================================
+ Hits         3741     4077     +336     
- Misses          5      265     +260     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eacharles eacharles self-requested a review February 26, 2026 20:57

@eacharles eacharles left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jscora jscora merged commit e938874 into main Feb 26, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants