Skip to content

Update dnf.py metric_computation function#11

Merged
ltoribiosc merged 1 commit intomainfrom
ltoribiosc-patch-2
May 6, 2025
Merged

Update dnf.py metric_computation function#11
ltoribiosc merged 1 commit intomainfrom
ltoribiosc-patch-2

Conversation

@ltoribiosc
Copy link
Copy Markdown
Collaborator

The update makes the feature sort galaxies faster.

Problem & Solution Description (including issue #)

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

The update makes the feature sort galaxies faster.
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (0776e57) to head (a99237d).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #11   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files           1        1           
  Lines         223      227    +4     
=======================================
+ Hits          222      226    +4     
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ltoribiosc ltoribiosc requested a review from hangqianjun May 6, 2025 11:17
Copy link
Copy Markdown

@hangqianjun hangqianjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@ltoribiosc ltoribiosc merged commit 4a04507 into main May 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants