Skip to content

Update dnf.py#13

Merged
sschmidt23 merged 5 commits intomainfrom
ltoribiosc-patch-3
Jul 11, 2025
Merged

Update dnf.py#13
sschmidt23 merged 5 commits intomainfrom
ltoribiosc-patch-3

Conversation

@ltoribiosc
Copy link
Copy Markdown
Collaborator

Change presel number
Change option fit in dnf_photometric_redshift
Add manage_nan function
Change metric_computation

  • return z1, id1, d1 Change compute_photoz_mean_routliers Change compute_photoz_fit Add compute_pdfs_fit

Problem & Solution Description (including issue #)

Code Quality

  • My code follows the code style of this project
  • I have written unit tests or justified all instances of #pragma: no cover; in the case of a bugfix, a new test that breaks as a result of the bug has been added
  • My code contains relevant comments and necessary documentation for future maintainers; the change is reflected in applicable demos/tutorials (with output cleared!) and added/updated docstrings use the NumPy docstring format
  • Any breaking changes, described above, are accompanied by backwards compatibility and deprecation warnings

Change presel number
Change option fit in dnf_photometric_redshift
Add manage_nan function
Change metric_computation
 - return z1, id1, d1
 Change compute_photoz_mean_routliers
 Change compute_photoz_fit
Add compute_pdfs_fit
@ltoribiosc ltoribiosc requested a review from sschmidt23 July 10, 2025 13:25
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (b7b3ee9) to head (a365936).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   99.55%   99.59%   +0.03%     
==========================================
  Files           1        1              
  Lines         227      245      +18     
==========================================
+ Hits          226      244      +18     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ztq1996
Copy link
Copy Markdown
Contributor

ztq1996 commented Jul 10, 2025

There is one line that is not unit tested:

  •     if pdf:
    
  •         Vpdf=compute_pdfs_fit(photoz, photozerr, zgrid)
    
  •     else:
    
  •         Vpdf=None  
    

A fix would be

          Vpdf = None
          if pdf:
              Vpdf = compute_pdfs_fit(photoz, photozerr, zgrid)

Copy link
Copy Markdown
Contributor

@sschmidt23 sschmidt23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, everything now works

@sschmidt23 sschmidt23 merged commit 58defd4 into main Jul 11, 2025
5 checks passed
@sschmidt23 sschmidt23 deleted the ltoribiosc-patch-3 branch July 11, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants