First usable if incomplete CI#1
Conversation
…[full]" in pyproject
|
Although there is more to do here, in particular in the CI, I would like to merge now so that there is a usable version of the code on the main branch. For the most part the code has been extracted with little or no change from the skyCatalogs repo. Other than minor clean-up, differences are
|
…ed ones. New files include not only the test but also small cosmodc2 galaxy source files, extracted from standard gcr catalog code to create the sparsified files the "standard" cosmodc2 galaxy skycatalogs Modified ci.yaml and main_catalog_creator.py to support the new test.
|
@jchiang87 There is now a test for comparing a newly-created cosmodc2 galaxy catalog to a standard as well as a similar test for TRILEGAL. I don't expect to do any more along these lines. Please take a look when you have a chance. |
jchiang87
left a comment
jchiang87
left a comment
There was a problem hiding this comment.
I left a couple comments on lsst stack versions to use in the install docs and the conda requirements file, otherwise looks ok to me.
| Load and setup the science pipelines | ||
| ++++++++++++++++++++++++++++++++++++ | ||
|
|
||
| First you need to setup the science pipelines. This involves sourcing a setup file and then using the Rubin *eups* commands to set them up. |
There was a problem hiding this comment.
It would be good to update the version of the Rubin code to use to something more recent than w_2024_20. I don't know what the earliest viable version is, but something that uses GalSim v2.7.2 would at least make things consistent with the most recen imSim release. Also, these instructions still point to /cvmfs/sw.lsst.eu/linux-x86_64 builds, which have been deprecated.
There was a problem hiding this comment.
I think w_2025_28, specified in the imSim conda_requirements, will be ok.
| @@ -0,0 +1,8 @@ | |||
| # conda install --file etc/conda_requirements should install all required dependencies of imSim including a conda based version of the Rubin pipelines. | |||
|
|
|||
| stackvana>=0.2023.32 | |||
There was a problem hiding this comment.
I think the minimal version specified here should match what's recommended in the install instructions.
2 participants
Exercises two "create" scripts (
create_main.pyandcreate_flux.pyto a degree by--help