Specify that ang_min/ang_max are specified in angstrom#5
Merged
sidneymau merged 1 commit intoLSSTDESC:mainfrom Feb 3, 2026
Merged
Specify that ang_min/ang_max are specified in angstrom#5sidneymau merged 1 commit intoLSSTDESC:mainfrom
sidneymau merged 1 commit intoLSSTDESC:mainfrom
Conversation
Collaborator
|
@sidneymau would you like me to review this now or are you thinking of making more commits? |
Contributor
Author
|
Happy for it to be reviewed -- I didn't see any other places where it would be important to specify units around the diffsky code. I'll be working on a larger PR for supporting the next gen diffsky mocks once some other code is in place, but that's a whole separate topic |
JoanneBogart
approved these changes
Feb 3, 2026
Collaborator
JoanneBogart
left a comment
JoanneBogart
left a comment
There was a problem hiding this comment.
LGTM
I've given you write permission to the repository; feel free to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to clarify units of ang_min/ang_max