feat(core) EspressoVM compatibility #1003
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewurm
changed the title
`reserved0` is used by EspressoVM, thus it cannot serve as a "reference NULL" as on HotSpot: https://github.com/oracle/graal/blob/3149f62458029ffe92b8dcefe0b3e59612684cfa/espresso/src/com.oracle.truffle.espresso.mokapot/include/mokapot.h#L67-L73 The relevant config is `MOKA_LATTE`. `reserved3` is `NULL` though.
lewurm
force-pushed
the
reserved3-espressovm
branch
from
ad4e87e
to
2756241
Compare
modules/lwjgl/core/src/main/java/org/lwjgl/system/ThreadLocalUtil.java
Outdated
Show resolved
Hide resolved
modules/lwjgl/core/src/main/java/org/lwjgl/system/ThreadLocalUtil.java
Outdated
Show resolved
Hide resolved
modules/lwjgl/core/src/main/java/org/lwjgl/system/ThreadLocalUtil.java
Outdated
Show resolved
Hide resolved
lewurm
force-pushed
the
reserved3-espressovm
branch
from
d12cf34
to
c8a8187
Compare
modules/lwjgl/core/src/main/java/org/lwjgl/system/ThreadLocalUtil.java
Outdated
Show resolved
Hide resolved
|
I have ran into this issue myself, what if all reversed slots are in use? Won't it be better to copy JNIEnv with one more pointer in the function table? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reserved0is used by EspressoVM, thus it cannot serve as a "reference NULL" as on HotSpot: https://github.com/oracle/graal/blob/3149f62458029ffe92b8dcefe0b3e59612684cfa/espresso/src/com.oracle.truffle.espresso.mokapot/include/mokapot.h#L67-L73The relevant config is
MOKA_LATTE.reserved3isNULLthough.EspressoVM aka. Java on Truffle: https://www.graalvm.org/latest/reference-manual/java-on-truffle/
I tested the fix with Espresso, but I'm not 100% sure about the implications for other implementations. So please understand this PR more like a bug report 🙂 In general, I saw that in #875 (comment) it is mentioned that you want to get rid of (ab)using
reserved3, so I think that's the better fix going forward.