LibWeb: Report exceptions that occur during resize observer callback

LadybirdBrowser · Dec 19, 2024 · e74d8a6 · e74d8a6
1 parent 62ecff0
commit e74d8a6
Show file tree

Hide file tree

Showing 3 changed files with 37 additions and 3 deletions.
diff --git a/Libraries/LibWeb/ResizeObserver/ResizeObserver.cpp b/Libraries/LibWeb/ResizeObserver/ResizeObserver.cpp
@@ -109,9 +109,7 @@ void ResizeObserver::invoke_callback(ReadonlySpan<GC::Ref<ResizeObserverEntry>>
         MUST(wrapped_records->create_data_property(property_index, record.ptr()));
     }
 
-    auto result = WebIDL::invoke_callback(callback, JS::js_undefined(), wrapped_records);
-    if (result.is_abrupt())
-        HTML::report_exception(result, realm);
+    (void)WebIDL::invoke_callback(callback, JS::js_undefined(), WebIDL::ExceptionBehavior::Report, wrapped_records);
 }
 
 }
diff --git a/...LibWeb/Text/expected/wpt-import/resize-observer/callback-cross-realm-report-exception.txt b/...LibWeb/Text/expected/wpt-import/resize-observer/callback-cross-realm-report-exception.txt
@@ -0,0 +1,6 @@
+Harness status: OK
+
+Found 1 tests
+
+1 Pass
+Pass	ResizeObserver reports the exception from its callback in the callback's global object
diff --git a/...s/LibWeb/Text/input/wpt-import/resize-observer/callback-cross-realm-report-exception.html b/...s/LibWeb/Text/input/wpt-import/resize-observer/callback-cross-realm-report-exception.html
@@ -0,0 +1,30 @@
+<!doctype html>
+<meta charset=utf-8>
+<title>ResizeObserver reports the exception from its callback in the callback's global object</title>
+<script src=../resources/testharness.js></script>
+<script src=../resources/testharnessreport.js></script>
+<iframe srcdoc='<div style="height: 100px;">foo</div>'></iframe>
+<iframe></iframe>
+<iframe></iframe>
+<script>
+setup({ allow_uncaught_exception: true });
+
+const onerrorCalls = [];
+window.onerror = () => { onerrorCalls.push("top"); };
+frames[0].onerror = () => { onerrorCalls.push("frame0"); };
+frames[1].onerror = () => { onerrorCalls.push("frame1"); };
+frames[2].onerror = () => { onerrorCalls.push("frame2"); };
+
+async_test(t => {
+  window.onload = t.step_func(() => {
+    const target = frames[0].document.querySelector("div");
+    const io = new frames[0].ResizeObserver(new frames[1].Function(`throw new parent.frames[2].Error("PASS");`));
+    io.observe(target);
+
+    t.step_timeout(() => {
+      assert_array_equals(onerrorCalls, ["frame1"]);
+      t.done();
+    }, 25);
+  });
+});
+</script>