Skip to content

Conversation

@andornaut
Copy link

@andornaut andornaut commented Dec 13, 2023

Specify a greater-than dependency specification for dacite in order to not unnecessarily constrain other integrations that may want to use newer versions.

@andornaut
Copy link
Author

andornaut commented Dec 17, 2023

@LaggAt Note that this PR restores compatibility with the Roborock integration, whereas #124 does not.

See also #132.

@Dillton
Copy link

Dillton commented Jan 20, 2024

Are you sure this really solves the issue?
I had some time to play with and after modifying manifest.json and HA restart
the Roborock integration was dead again at my side.

However removing the dacite dependancy completeley see #148 solved the problem for good.

@andornaut
Copy link
Author

andornaut commented Jan 20, 2024

@Dillton I'm sure it worked for me. Here's the Ansible task I used to apply it to my container installation of HA.

You can use pip show dacite to check what version is installed:

$ docker exec -ti homeassistant pip show dacite
Name: dacite
Version: 1.8.1
...

I've since switched to Govee LAN, though, which side-steps this issue. You can also consider using Govee2MQTT.

IMHO, removing the dependency on dacite is an even better fix. So, I hope #148 can be merged, but if not then this could still help some folks.

@LaggAt LaggAt closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants