feat/native-sync-vault-composer

examples/ovault-evm/test/vault-sync/VaultComposerSync_ProxySend.t.sol

@@ -22,7 +22,7 @@ contract VaultComposerSyncProxySendTest is VaultComposerSyncBaseTest {
         vm.deal(userA, 100 ether);
     }
 
-    function test_target_is_hub_reverts_when_msg_value_provided() public {
+    function test_target_is_hub_does_not_revert_when_msg_value_provided() public {
         SendParam memory sendParam = SendParam(ARB_EID, addressToBytes32(userA), TOKENS_TO_SEND, 0, "", "", "");
         assetOFT_arb.mint(address(userA), TOKENS_TO_SEND);
         vault_arb.mint(address(userA), TOKENS_TO_SEND);
@@ -31,11 +31,11 @@ contract VaultComposerSyncProxySendTest is VaultComposerSyncBaseTest {
         assetOFT_arb.approve(address(VaultComposerSyncArb), TOKENS_TO_SEND);
         vault_arb.approve(address(VaultComposerSyncArb), TOKENS_TO_SEND);
 
-        vm.expectRevert(IVaultComposerSync.NoMsgValueExpected.selector);
         VaultComposerSyncArb.depositAndSend{ value: 1 wei }(TOKENS_TO_SEND, sendParam, userA);
+        assertEq(address(VaultComposerSyncArb).balance, 1 wei);
 
-        vm.expectRevert(IVaultComposerSync.NoMsgValueExpected.selector);
         VaultComposerSyncArb.redeemAndSend{ value: 2 wei }(TOKENS_TO_SEND, sendParam, userA);
+        assertEq(address(VaultComposerSyncArb).balance, 3 wei);
         vm.stopPrank();
     }
 

examples/ovault-evm/test/vault-sync/VaultComposerSync_Unit.t.sol

@@ -119,40 +119,6 @@ contract VaultComposerSyncUnitTest is VaultComposerSyncBaseTest {
         assertEq(vault_arb.totalSupply(), vault_arb.balanceOf(address(userA)), TOKENS_TO_SEND);
     }
 
-    function test_lzCompose_pass_dst_is_hub_no_msgValue_causes_refund() public {
-        bytes32 guid = _randomGUID();
-        assetOFT_arb.mint(address(VaultComposerSyncArb), TOKENS_TO_SEND);
-        uint256 userABalanceEth = assetOFT_eth.balanceOf(userA);
-
-        SendParam memory internalSendParam = SendParam(
-            VaultComposerSyncArb.VAULT_EID(),
-            addressToBytes32(userA),
-            TOKENS_TO_SEND,
-            0,
-            "",
-            "",
-            ""
-        );
-
-        bytes memory composeMsg = _createComposePayload(ETH_EID, internalSendParam, 1 wei, TOKENS_TO_SEND, userA);
-
-        /// @dev Internal revert on try...catch
-        /// vm.expectRevert(abi.encodeWithSelector(IVaultComposerSync.NoMsgValueExpected.selector));
-
-        vm.expectEmit(true, true, true, true, address(VaultComposerSyncArb));
-        emit IVaultComposerSync.Refunded(guid);
-
-        vm.prank(arbEndpoint);
-        VaultComposerSyncArb.lzCompose{ value: 1 ether }(address(assetOFT_arb), guid, composeMsg, arbExecutor, "");
-
-        verifyPackets(ETH_EID, address(assetOFT_eth));
-        assertEq(
-            assetOFT_eth.balanceOf(userA),
-            userABalanceEth + TOKENS_TO_SEND,
-            "userA should have received refund on Ethereum"
-        );
-    }
-
     function test_lzCompose_fail_invalid_payload_auto_refunds() public {
         bytes32 guid = _randomGUID();
         assetOFT_arb.mint(address(VaultComposerSyncArb), TOKENS_TO_SEND);

packages/ovault-evm/.gitignore

@@ -4,12 +4,9 @@ cache
 # artifacts;  ignore all files except the local contract artifacts.
 artifacts/*
 !artifacts/VaultComposerSync.sol/
+!artifacts/VaultComposerSyncNative.sol/
 !artifacts/IVaultComposerSync.sol/
-!artifacts/VaultComposerSync_Base.t.sol
-!artifacts/VaultComposerSync_E2E.t.sol
-!artifacts/VaultComposerSync_ProxySend.t.sol
-!artifacts/VaultComposerSync_Unit.t.sol
-
+!artifacts/IVaultComposerSyncNative.sol/
 
 # sdk 
 .env

packages/ovault-evm/README.md

@@ -26,8 +26,7 @@ pnpm install @layerzerolabs/ovault-evm
 npm install @layerzerolabs/ovault-evm
 ```
 
-
-## Ovault SDK 
+## Ovault SDK
 
 This is an SDK to make depositing/redeeming on OVaults simple.
 
@@ -126,6 +125,12 @@ const tx = await walletClient.writeContract({
 For more example usage you can check `./test/sdk.test.ts`. It will run transactions against the deployed OVault contracts
 on Base-Sepolia and Arbitrum-Sepolia
 
+### Using Stargate native pools
+If you are staking in Stargate's native pools you will need a slightly different setup. As the asset is the native token there is not
+really an OFT or an ERC20 address. So for the asset OFT and ERC20 address you need to supply the Native Pool and `0x0`(or some other 0 value hex string).
+The Native Pool implements the OFT interface, and the `0x0` address will let the library know that it should handle it as a native pool. Other than that
+it is the same. If you are using wETH, you can supply arguments normally. This is just for ETH or other native tokens specifically.
+
 #### Adding Buffer to Hub Chain Fee
 You can add a buffer to the fee on the hub chain by override the `calculateHubChainFee` function.