generate lockfiles script: throw if pnpm used is not v8 #1787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazreen
changed the title
nazreen
force-pushed
the
update-gen-lockfiles-script
branch
from
9d58f43 to
e3ec16e
Compare
nazreen
changed the title
tinom9
approved these changes
Nov 5, 2025
Comment on lines
+56
to
+63
| function getExpectedVersionFromPackageJson() { | ||
| const packageJson = JSON.parse(readFileSync(join(process.cwd(), 'package.json'), 'utf8')); | ||
| const packageManager = packageJson.packageManager; | ||
| if (!packageManager?.startsWith('pnpm@')) { | ||
| throw new Error(`Invalid packageManager: ${packageManager || 'missing'}. Expected format: "[email protected]"`); | ||
| } | ||
| return packageManager.slice(5); // Remove "pnpm@" prefix | ||
| } |
There was a problem hiding this comment.
This assumes that we will always have fixed versions and no trailing hash (example here https://github.com/LayerZero-Labs/docs/blob/main/package.json#L102).
I think it's a safe assumption given the timeline of the repo though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
verify lockfilesCI job expects lockfiles to be generated by pnpm v8 but in some cases a different version of pnpm might be used - leading to incorrect lockfiles being generated.Problem
Currently, running
pnpm lockfiles:generateon a local machine may result in lockfiles that would be rejected by theverify lockfilesCI job. This can happen due to the generate lockfiles script using the local machine's version ofpnpm, disregarding thepackageManagerversion of pnpm frompackage.json. This results in lockfiles withlockfileVersion: 9.0whereas the CI job expectslockfileVersion: 6.0Changes
Validate that the pnpm version used matches the one set in
package.json