Fix/middleware #30
Merged
Fix/middleware #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt error responses - Introduces the `ExceptionHandler` class to handle exceptions and return consistent JSON error responses across the application. - Maps specific Django exceptions (e.g., `ObjectDoesNotExist`, `ValidationError`, `DatabaseError`) to appropriate HTTP status codes and messages. - Provides detailed error information in debug mode, including exception type, message, and traceback. - Supports handling of common Django exceptions (e.g., `PermissionDenied`, `BadRequest`, `IntegrityError`) and falls back to a generic 500 Internal Server Er ror for unhandled exceptions. Closes Lazarus-org#29
- Added async-aware logic to handle both synchronous and asynchronous requests seamlessly using Django's `sync_to_async` utility. - Updated the `BaseMiddleware` class to support async mode by checking if the `get_response` function is a coroutine and marking the middleware as async-capa ble. - Ensured compatibility with Django's ASGI stack by properly handling async responses and exceptions. - Maintained existing synchronous functionality while extending support for async workflows, ensuring backward compatibility. - Added async-specific logic to process JSON responses consistently for both success and error cases. - Improved exception handling to work seamlessly in both sync and async contexts, leveraging the `ExceptionHandler` class for consistent error responses. Closes Lazarus-org#28
Collaborator
Author
MEHRSHAD-MIRSHEKARY
left a comment
MEHRSHAD-MIRSHEKARY
left a comment
There was a problem hiding this comment.
Fixed two issues related to middleware,
I will update the dependencies & configuration files in the next PR.
ARYAN-NIKNEZHAD
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.