[Fix/stacks] transaction broadcast API error (#9137)

* fix(stx): broadcast failure due to wrong fee

* chore: changeset

.changeset/small-hornets-accept.md

@@ -0,0 +1,5 @@
+---
+"@ledgerhq/coin-stacks": patch
+---
+
+Fix transaction broadcast

libs/coin-modules/coin-stacks/src/bridge/estimateMaxSpendable.ts

@@ -5,6 +5,7 @@ import { StacksMainnet } from "@stacks/network";
 import {
   UnsignedTokenTransferOptions,
   estimateTransaction,
+  estimateTransactionByteLength,
   makeUnsignedSTXTokenTransfer,
 } from "@stacks/transactions";
 import BigNumber from "bignumber.js";
@@ -43,7 +44,7 @@ export const estimateMaxSpendable: AccountBridge<Transaction>["estimateMaxSpenda
 
   const tx = await makeUnsignedSTXTokenTransfer(options);
 
-  const [feeEst] = await estimateTransaction(tx.payload);
+  const [feeEst] = await estimateTransaction(tx.payload, estimateTransactionByteLength(tx));
 
   const diff = spendableBalance.minus(new BigNumber(feeEst.fee));
   return diff.gte(0) ? diff : new BigNumber(0);

libs/coin-modules/coin-stacks/src/bridge/prepareTransaction.ts

@@ -6,6 +6,7 @@ import {
   TransactionVersion,
   UnsignedTokenTransferOptions,
   estimateTransaction,
+  estimateTransactionByteLength,
   makeUnsignedSTXTokenTransfer,
 } from "@stacks/transactions";
 import BigNumber from "bignumber.js";
@@ -48,7 +49,7 @@ export const prepareTransaction: AccountBridge<Transaction>["prepareTransaction"
         : AddressVersion.TestnetSingleSig;
     const senderAddress = c32address(addressVersion, tx.auth.spendingCondition!.signer);
 
-    const [fee] = await estimateTransaction(tx.payload);
+    const [fee] = await estimateTransaction(tx.payload, estimateTransactionByteLength(tx));
 
     patch.fee = new BigNumber(fee.fee);
     patch.nonce = await findNextNonce(senderAddress, pendingOperations);