Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coin:tezos): handle missing recipients or senders cleanly #9126

Open
wants to merge 2 commits into
base: back-8291_xrp_add_memo
Choose a base branch
from
Open

fix(coin:tezos): handle missing recipients or senders cleanly #9126

wants to merge 2 commits into from
+125 −7

Conversation

jprudent
Copy link
Contributor

@jprudent jprudent commented Feb 5, 2025 •
edited
Loading

What's changed:

  • when recipients or senders is not found, it return an empty array instead of [""]
  • for delegate/undelegate operations, it adds the target adress as recipients

int tests: https://github.com/LedgerHQ/ledger-live/actions/runs/13200117088

@vercel Vercel
Copy link

vercel bot commented Feb 5, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2025 10:44am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 10:44am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 10:44am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 7, 2025 10:44am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools automation CI/CD stuff translations Translation files have been touched screenshots Screenshots have been updated cli labels Feb 5, 2025
@jprudent jprudent changed the base branch from main to develop February 5, 2025 17:09
@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools automation CI/CD stuff translations Translation files have been touched screenshots Screenshots have been updated cli labels Feb 6, 2025
@jprudent jprudent changed the base branch from develop to back-8291_xrp_add_memo February 6, 2025 08:53
@jprudent jprudent marked this pull request as ready for review February 6, 2025 08:54
@jprudent jprudent requested a review from a team as a code owner February 6, 2025 08:54
@jprudent jprudent changed the title fix tezos fix(coin:tezos): handle missing recipients or senders cleanly Feb 6, 2025
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Feb 6, 2025 •
edited
Loading

Mobile Bundle Checks

Comparing b8496d4 against 11975c0.

🚀 main.ios.jsbundle bundle size decreased (62.3mb -> 62.2mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (62.3mb -> 62.2mb). Thanks ❤️

Desktop Bundle Checks

Comparing b8496d4 against 6524dcf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jprudent jprudent

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jprudent