Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coin:tezos): api iterates over all results #9131

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

jprudent
Copy link
Contributor

@jprudent jprudent commented Feb 6, 2025

Changes:

  • the api retrieves operations from oldest to newest, bypassing explorer limit with iteration over pages

integration tests: https://github.com/LedgerHQ/ledger-live/actions/runs/13366400373
integration tests (old): https://github.com/LedgerHQ/ledger-live/actions/runs/13200265887

Copy link

vercel bot commented Feb 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 8:26am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 8:26am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 8:26am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 8:26am

@live-github-bot
Copy link
Contributor

live-github-bot bot commented Feb 7, 2025

Mobile Bundle Checks

Comparing 578b4c8 against 5485200.

✅ Previous issues have all been fixed.

Desktop Bundle Checks

Comparing 578b4c8 against 5485200.

✅ Previous issues have all been fixed.

@jprudent jprudent force-pushed the fix_tezos_pagination branch from b2f142e to 591dc1b Compare February 7, 2025 12:48
@jprudent jprudent marked this pull request as ready for review February 7, 2025 12:53
@jprudent jprudent requested a review from a team February 7, 2025 12:53
@jprudent jprudent force-pushed the fix_tezos branch 6 times, most recently from 784dda9 to 339a611 Compare February 14, 2025 08:12
Base automatically changed from fix_tezos to develop February 14, 2025 13:45
@jprudent jprudent force-pushed the fix_tezos_pagination branch 2 times, most recently from f34650f to 91b3a11 Compare February 17, 2025 07:50
@hedi-edelbloute hedi-edelbloute added this pull request to the merge queue Feb 21, 2025
Merged via the queue into develop with commit f9e1e7b Feb 21, 2025
59 checks passed
@hedi-edelbloute hedi-edelbloute deleted the fix_tezos_pagination branch February 21, 2025 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants