Skip to content

Fix issue-1117 - NBGL on Nano: issue with Streaming Review usecase#1120

Merged
nroggeman-ledger merged 1 commit into
masterfrom
fix-issue-with-streaming-use-case
Aug 28, 2025
Merged

Fix issue-1117 - NBGL on Nano: issue with Streaming Review usecase#1120
nroggeman-ledger merged 1 commit into
masterfrom
fix-issue-with-streaming-use-case

Conversation

@nroggeman-ledger

Copy link
Copy Markdown
Contributor

Description

The goal if this PR is to fix #1117

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Auto cherry-pick in API_LEVEL

If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:

[x] TARGET_API_LEVEL: API_LEVEL_24
[x] TARGET_API_LEVEL: API_LEVEL_25

This will only create the PR with cherry-picks, ready to be reviewed and merged.

Remember:

  • The merge will ALWAYS be a manual operation.
  • It is possible the cherry-picks don't apply correctly, mainly if previous commits have been forgotten.
  • In case of failure, there is no other solution than redo the operation manually...

@codecov-commenter

codecov-commenter commented Aug 22, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.29%. Comparing base (39b858f) to head (ebad38d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1120   +/-   ##
=======================================
  Coverage   62.29%   62.29%           
=======================================
  Files          13       13           
  Lines        1809     1809           
=======================================
  Hits         1127     1127           
  Misses        682      682           
Flag Coverage Δ
unittests 62.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nroggeman-ledger nroggeman-ledger force-pushed the fix-issue-with-streaming-use-case branch from 25219be to ebad38d Compare August 28, 2025 06:31
@nroggeman-ledger nroggeman-ledger merged commit 16f3cb7 into master Aug 28, 2025
221 checks passed
@nroggeman-ledger nroggeman-ledger deleted the fix-issue-with-streaming-use-case branch August 28, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

NBGL on Nano: issue with Streaming Review usecase

3 participants