Support TAG_VALUE_CONFIRM generiic content for Nano#1433
Merged
nroggeman-ledger merged 1 commit intomasterfrom Feb 19, 2026
Merged
Support TAG_VALUE_CONFIRM generiic content for Nano#1433nroggeman-ledger merged 1 commit intomasterfrom
nroggeman-ledger merged 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1433 +/- ##
=======================================
Coverage 91.82% 91.82%
=======================================
Files 37 37
Lines 4244 4244
Branches 521 521
=======================================
Hits 3897 3897
Misses 257 257
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yogh333
approved these changes
Feb 18, 2026
Contributor
yogh333
left a comment
There was a problem hiding this comment.
LGTM
Tested and approved for S+ and X with Speculos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The goal of this PR is to support TAG_VALUE_CONFIRM generic content for Nano.
Indeed, currently this type of generic content is only supported on Flex/Stax
Changes include
Auto cherry-pick in API_LEVEL
If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:
[x] TARGET_API_LEVEL: API_LEVEL_25
This will only create the PR with cherry-picks, ready to be reviewed and merged.
Remember: