Skip to content

Support TAG_VALUE_CONFIRM generiic content for Nano#1433

Merged
nroggeman-ledger merged 1 commit intomasterfrom
support-tag-value-list-confirm-on-nano
Feb 19, 2026
Merged

Support TAG_VALUE_CONFIRM generiic content for Nano#1433
nroggeman-ledger merged 1 commit intomasterfrom
support-tag-value-list-confirm-on-nano

Conversation

@nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to support TAG_VALUE_CONFIRM generic content for Nano.
Indeed, currently this type of generic content is only supported on Flex/Stax

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Auto cherry-pick in API_LEVEL

If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:

[x] TARGET_API_LEVEL: API_LEVEL_25

This will only create the PR with cherry-picks, ready to be reviewed and merged.

Remember:

  • The merge will ALWAYS be a manual operation.
  • It is possible the cherry-picks don't apply correctly, mainly if previous commits have been forgotten.
  • In case of failure, there is no other solution than redo the operation manually...

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.82%. Comparing base (607d181) to head (55c21b0).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1433   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files          37       37           
  Lines        4244     4244           
  Branches      521      521           
=======================================
  Hits         3897     3897           
  Misses        257      257           
  Partials       90       90           
Flag Coverage Δ
unittests 91.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@yogh333 yogh333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Tested and approved for S+ and X with Speculos

@nroggeman-ledger nroggeman-ledger merged commit 0550840 into master Feb 19, 2026
404 of 405 checks passed
@nroggeman-ledger nroggeman-ledger deleted the support-tag-value-list-confirm-on-nano branch February 19, 2026 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants