Skip to content

Re-introduce os_registry_get_current_app_tag#1435

Merged
abonnaudet-ledger merged 2 commits intomasterfrom
abo_reintroduce_get_current_app_tag
Feb 19, 2026
Merged

Re-introduce os_registry_get_current_app_tag#1435
abonnaudet-ledger merged 2 commits intomasterfrom
abo_reintroduce_get_current_app_tag

Conversation

@abonnaudet-ledger
Copy link
Member

Description

The replacement of os_registry_get_current_app_tag with hardcoded defines, broke the swap flow.
This PR revert those changes.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Breaking changes

Please complete this section if any breaking changes have been made, otherwise delete it.

Additional comments

Please post additional comments in this section if you have them, otherwise delete it.

Auto cherry-pick in API_LEVEL

If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:

[ ] TARGET_API_LEVEL: API_LEVEL_25

This will only create the PR with cherry-picks, ready to be reviewed and merged.

Remember:

  • The merge will ALWAYS be a manual operation.
  • It is possible the cherry-picks don't apply correctly, mainly if previous commits have been forgotten.
  • In case of failure, there is no other solution than redo the operation manually...

@abonnaudet-ledger abonnaudet-ledger force-pushed the abo_reintroduce_get_current_app_tag branch from 8f48781 to 52983dc Compare February 19, 2026 08:28
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.82%. Comparing base (0550840) to head (52983dc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1435   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files          37       37           
  Lines        4244     4244           
  Branches      521      521           
=======================================
  Hits         3897     3897           
  Misses        257      257           
  Partials       90       90           
Flag Coverage Δ
unittests 91.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@abonnaudet-ledger abonnaudet-ledger merged commit 12d69ed into master Feb 19, 2026
244 checks passed
@abonnaudet-ledger abonnaudet-ledger deleted the abo_reintroduce_get_current_app_tag branch February 19, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants