Skip to content

Support Address Book specific display in NBGL#1436

Merged
nroggeman-ledger merged 1 commit intomasterfrom
support-address-book-in-nbgl
Feb 19, 2026
Merged

Support Address Book specific display in NBGL#1436
nroggeman-ledger merged 1 commit intomasterfrom
support-address-book-in-nbgl

Conversation

@nroggeman-ledger
Copy link
Contributor

Description

The goal of this PR is to support Address Book specific display in NBGL, for wallet-size devices, as specified in https://www.figma.com/design/k9Q6hP0XWAw00AiT6GDb0O/02.-App-SDK?node-id=5980-111284&t=AaNNGj6r6eHrkMlV-4

Screenshots are added to validate this display

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

@codecov-commenter
Copy link

codecov-commenter commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.82%. Comparing base (12d69ed) to head (4dd65ca).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1436   +/-   ##
=======================================
  Coverage   91.82%   91.82%           
=======================================
  Files          37       37           
  Lines        4244     4244           
  Branches      521      521           
=======================================
  Hits         3897     3897           
  Misses        257      257           
  Partials       90       90           
Flag Coverage Δ
unittests 91.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@cedelavergne-ledger cedelavergne-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rien de plus que @tdejoigny-ledger

@nroggeman-ledger nroggeman-ledger force-pushed the support-address-book-in-nbgl branch from ab3b261 to 4dd65ca Compare February 19, 2026 12:51
@nroggeman-ledger nroggeman-ledger merged commit db9603e into master Feb 19, 2026
244 checks passed
@nroggeman-ledger nroggeman-ledger deleted the support-address-book-in-nbgl branch February 19, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants