Skip to content

Change page index to uint #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cedelavergne-ledger merged 1 commit into from
Mar 12, 2026
Merged

Change page index to uint #1458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib_nbgl/src/nbgl_use_case_nanos.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,8 +159,8 @@ typedef struct UseCaseContext_s {
ContextType_t type;
nbgl_operationType_t operationType;
uint8_t nbPages;
int8_t currentPage;
int8_t firstPairPage;
uint8_t currentPage;
uint8_t firstPairPage;
bool forceAction;
nbgl_stepCallback_t
stepCallback; ///< if not NULL, function to be called on "double-key" action
Expand Down Expand Up @@ -279,11 +279,11 @@ static uint8_t getContentNbElement(const nbgl_content_t *content)
// Helper to retrieve the content inside a nbgl_genericContents_t using
// either the contentsList or using the contentGetterCallback
static const nbgl_content_t *getContentAtIdx(const nbgl_genericContents_t *genericContents,
int8_t contentIdx,
uint8_t contentIdx,
nbgl_content_t *content)
{
nbgl_pageContent_t pageContent = {0};
if (contentIdx < 0 || contentIdx >= genericContents->nbContents) {
if (contentIdx >= genericContents->nbContents) {
LOG_DEBUG(USE_CASE_LOGGER, "No content available at %d\n", contentIdx);
return NULL;
}
Expand Down Expand Up @@ -369,7 +369,7 @@ static const nbgl_content_t *getContentElemAtIdx(uint8_t elemIdx,
default:
return NULL;
}
for (int i = 0; i < genericContents->nbContents; i++) {
for (uint i = 0; i < genericContents->nbContents; i++) {
p_content = getContentAtIdx(genericContents, i, content);
elemNbPages = getContentNbElement(p_content);
if (nbPages + elemNbPages > elemIdx) {
Expand Down Expand Up @@ -1577,7 +1577,7 @@ static void startUseCaseSettingsAtPage(uint8_t initSettingPage)
}

context.nbPages = 1; // For back screen
for (int i = 0; i < context.home.settingContents->nbContents; i++) {
for (uint i = 0; i < context.home.settingContents->nbContents; i++) {
p_content = getContentAtIdx(context.home.settingContents, i, &content);
context.nbPages += getContentNbElement(p_content);
}
Expand Down
Loading