Skip to content

Fix NBGL#1624

Merged
yogh333 merged 1 commit into
masterfrom
y333/nbgl_fix_pagination
Jul 2, 2026
Merged

Fix NBGL#1624
yogh333 merged 1 commit into
masterfrom
y333/nbgl_fix_pagination

Conversation

@yogh333

@yogh333 yogh333 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Description

Fix NBGL pagination issue

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Tests
  • Documentation
  • Other (for changes that might not fit in any category)

Auto cherry-pick in API_LEVEL

If requested to port the commits from this PR on a dedicated API_LEVEL branch,
select the targeted one(s), or add new references if not listed:

[x] TARGET_API_LEVEL: API_LEVEL_26

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.87%. Comparing base (8acc42a) to head (c9d607f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1624   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files          39       39           
  Lines        4653     4653           
  Branches      596      596           
=======================================
  Hits         4275     4275           
  Misses        266      266           
  Partials      112      112           
Flag Coverage Δ
unittests 91.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes an NBGL review pagination bug where page height estimation could be under-allocated when nbMaxLinesForValue is set below the review rendering cap, causing content to be drawn off-screen.

Changes:

  • Adjusts tag/value page height estimation to ignore nbMaxLinesForValue values that are smaller than NB_MAX_LINES_IN_REVIEW, aligning pagination with the effective review rendering behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread lib_nbgl/src/nbgl_use_case.c
@yogh333 yogh333 merged commit 303dfc8 into master Jul 2, 2026
235 checks passed
@yogh333 yogh333 deleted the y333/nbgl_fix_pagination branch July 2, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants