WDLRescale() cleanup #1953
Open
WDLRescale() cleanup #1953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naphthalin
reviewed
Feb 21, 2024
Naphthalin
reviewed
Feb 21, 2024
src/mcts/search.cc
Outdated
| wdl_rescale_diff_ = | ||
| contempt_mode_ == ContemptMode::NONE | ||
| ? 0 | ||
| : params_.GetWDLRescaleDiff() * params_.GetWDLEvalObjectivity(); |
There was a problem hiding this comment.
That's unfortunately not how it works -- WDLEvalObjectivity is only supposed to be applied when invert is set.
There was a problem hiding this comment.
Best solution probably is to define a "forwards" and an "invert" wdl_rescale_diff_ here if the goal is to avoid any params_.Get...() calls.
There was a problem hiding this comment.
Ah, I missed that. I'll think about it.
There was a problem hiding this comment.
I decided to store the value in wdl_eval_objectivity_, seems cleaner this way to keep all the logic inside WDLRescale():
float wdl_rescale_diff =
invert ? -wdl_rescale_diff_ * wdl_eval_objectivity_ : wdl_rescale_diff_;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.