Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modifying 'check if node_limit was initialized' to not fail if node_limit was set to 0, moving 'set node_limit to 4000000000 if it wasnt initialized' from stopper.h to common.cc #2056

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

modifying 'check if node_limit was initialized' to not fail if node_limit was set to 0, moving 'set node_limit to 4000000000 if it wasnt initialized' from stopper.h to common.cc #2056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4bf17f
fixing issue #2003
KarlKfoury Aug 29, 2024
3171d02
fixing issue #2003
KarlKfoury Aug 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/mcts/stoppers/common.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,12 +126,12 @@ void PopulateCommonUciStoppers(ChainedSearchStopper* stopper,

// "go nodes" stopper.
int64_t node_limit = 0;
if (params.nodes) {
if (params.nodes.has_value()) {
if (options.Get<bool>(kNodesAsPlayoutsId)) {
stopper->AddStopper(std::make_unique<PlayoutsStopper>(
*params.nodes, options.Get<float>(kSmartPruningFactorId) > 0.0f));
} else {
node_limit = *params.nodes;
node_limit = 4000000000;
}
}
// always limit nodes to avoid exceeding the limit 4000000000. That number is
Expand Down
2 changes: 1 addition & 1 deletion src/mcts/stoppers/stoppers.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ class ChainedSearchStopper : public SearchStopper {
class VisitsStopper : public SearchStopper {
public:
VisitsStopper(int64_t limit, bool populate_remaining_playouts)
: nodes_limit_(limit ? limit : 4000000000ll),
: nodes_limit_(limit),
populate_remaining_playouts_(populate_remaining_playouts) {}
int64_t GetVisitsLimit() const { return nodes_limit_; }
bool ShouldStop(const IterationStats&, StoppersHints*) override;
Expand Down