Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node limit passed as 0 instead of a negative number to visits_stopper if nn cache > memory limit (prevents unsigned int variable overflow) #2058

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

KarlKfoury
Copy link
Contributor

@KarlKfoury KarlKfoury commented Aug 30, 2024

if cache size > ram limit, passing (ram limit) - (cache size) to visitsstopper as argument for node limit, which is an unsigned int, results in an error. Which is why it is necessary to pass 0 instead of (ram limit) - (cache size) if cache size > ram limit. Adressing issue #1597

… if nn cache > memory limit (prevents unsigned int variable overflow)

fixes LeelaChessZero#1597
properly closing before ram_limit*mb
@KarlKfoury KarlKfoury changed the title Issue 1597 node limit passed as 0 instead of a negative number to visits_stopper if nn cache > memory limit (prevents unsigned int variable overflow) Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant