Skip to content

Fix readme images.#6588

Open
dessalines wants to merge 3 commits into
mainfrom
fix_readme_images
Open

Fix readme images.#6588
dessalines wants to merge 3 commits into
mainfrom
fix_readme_images

Conversation

@dessalines

Copy link
Copy Markdown
Member

@dessalines dessalines marked this pull request as draft June 16, 2026 14:27
@dessalines dessalines marked this pull request as ready for review June 16, 2026 14:30
@Nutomic

Nutomic commented Jun 18, 2026

Copy link
Copy Markdown
Member

I dont think its a good idea to use a third party website. Better to put them in .github folder so its directly under our control and doesnt require extra network requests.

@dessalines

Copy link
Copy Markdown
Member Author

I think for these I'd rather keep them out of the git repos. They take up too much space, and have to belong to multiple repos anyway (lemmy, lemmy-ui, etc). postimgs isn't going away and should be okay.

@Nutomic

Nutomic commented Jun 22, 2026

Copy link
Copy Markdown
Member

The size of this repo is 38mb, and the images are 70kb so it really doesnt make a difference for the size. Having it directly in the repo means the screenshots also work offline, or if postimgs is unreachable for some reason.

Also the screenshots you used are from 0.19. Would be better to use 1.0 screenshots directly, otherwise we have to remember updating them later.

@dessalines

Copy link
Copy Markdown
Member Author

Maybe we can just wait until the 1.0 release to add them to the git repo then. Because the 1.0 UI may still change, and then we'll have to keep adding image diffs to the git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Screenshots in Readme are broken

2 participants