Skip to content

Commit

Permalink
test
Browse files Browse the repository at this point in the history 
Signed-off-by: LiangliangSui <[email protected]>
  • Loading branch information
@LiangliangSui
LiangliangSui committed Aug 1, 2024
1 parent ba4ac8e commit 56a8c85
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 198 deletions.
195 changes: 1 addition & 194 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ on:
push:
branches:
- main
- issue-1781
- 'releases/**'
- 'deploy/**'
- 'test*'
Expand All @@ -39,125 +40,6 @@ on:
types: ['opened', 'reopened', 'synchronize']

jobs:
java:
name: Java CI
runs-on: ubuntu-latest
env:
MY_VAR: "PATH"
strategy:
matrix:
java-version: ["8", "11", "17", "21"]
steps:
- uses: actions/checkout@v4
- name: Set up JDK ${{ matrix.java-version }}
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'temurin'
- name: Install bazel
run: ./ci/run_ci.sh install_bazel
- name: Install python
run: ./ci/run_ci.sh install_python
- name: Install pyfury
run: ./ci/run_ci.sh install_pyfury
- name: Run CI with Maven
run: ./ci/run_ci.sh java${{ matrix.java-version }}
openj9:
name: Openj9 Java CI
runs-on: ubuntu-latest
env:
MY_VAR: "PATH"
strategy:
matrix:
# String in openj9 1.8 share byte array by offset, fury doesn't allow it.
java-version: ["21"]
steps:
- uses: actions/checkout@v4
- name: Set up JDK ${{ matrix.java-version }}
uses: actions/setup-java@v4
with:
java-version: ${{ matrix.java-version }}
distribution: 'adopt-openj9'
- name: Install bazel
run: ./ci/run_ci.sh install_bazel
- name: Install python
run: ./ci/run_ci.sh install_python
- name: Install pyfury
run: ./ci/run_ci.sh install_pyfury
- name: Run CI with Maven
run: ./ci/run_ci.sh java${{ matrix.java-version }}
graalvm:
name: GraalVM CI
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: graalvm/setup-graalvm@v1
with:
java-version: '21'
distribution: 'graalvm'
github-token: ${{ secrets.GITHUB_TOKEN }}
native-image-job-reports: 'true'
- name: Build native image and run
run: ./ci/run_ci.sh graalvm_test

scala:
name: Scala CI
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up JDK8
uses: actions/setup-java@v4
with:
java-version: 8
distribution: 'temurin'
- name: Install fury java
run: cd java && mvn -T10 --no-transfer-progress clean install -DskipTests && cd -
- name: Test
run: |
# Avoid sbt download jackson-databind error
rm -rf /home/runner/.m2/repository/com/fasterxml/jackson/
cd scala && sbt +test && cd -
integration_tests:
name: Integration Tests
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up JDK8
uses: actions/setup-java@v4
with:
java-version: 8
distribution: 'temurin'
- name: Run CI
run: ./ci/run_ci.sh integration_tests

javascript:
name: JavaScript CI
strategy:
matrix:
node-version: [14.x, 16.x, 18.x, 20.x]
os: [ubuntu-latest, macos-13, windows-2022]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- name: Upgrade npm
run: npm install -g npm@8
# node-gyp needs to use python and relies on the distutils module.
# The distutils module has been removed starting from python 3.12
# (see https://docs.python.org/3.10/library/distutils.html). Some
# OS (such as macos -latest) uses python3.12 by default, so python 3.8
# is used here to avoid this problem.
- name: Set up Python3.8
uses: actions/setup-python@v5
with:
python-version: 3.8
- name: Run CI with NodeJS
run: python ./ci/run_ci.py javascript

rust:
name: Rust CI
strategy:
Expand All @@ -173,78 +55,3 @@ jobs:
python-version: 3.11
- name: Run Rust CI
run: python ./ci/run_ci.py rust

cpp:
name: C++ CI
strategy:
matrix:
os: [ubuntu-latest, macos-12, macos-14] # macos-12: x86, macos-14: arm64
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
- name: Set up Python 3.11
uses: actions/setup-python@v5
with:
python-version: 3.11
- name: Run C++ CI with Bazel
run: python ./ci/run_ci.py cpp
python:
name: Python CI
# Fix python 3.6 install issue, see
# https://github.com/rwth-i6/returnn/commit/38ecab17d781c4b74db6a174c8097187380b4ddc
runs-on: ubuntu-20.04
strategy:
matrix:
python-version: [3.7, 3.12]
steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- name: Install bazel
run: ./ci/run_ci.sh install_bazel
- name: Run Python CI
run: ./ci/run_ci.sh python

go:
name: Golang CI
runs-on: ubuntu-latest
strategy:
matrix:
go-version: [ '1.13', '1.18' ]
steps:
- uses: actions/checkout@v4
- name: Setup Go ${{ matrix.go-version }}
uses: actions/setup-go@v4
with:
go-version: ${{ matrix.go-version }}
- name: Display Go version
run: go version
- name: Install bazel
run: ./ci/run_ci.sh install_bazel
- name: Install python
run: ./ci/run_ci.sh install_python
- name: Install pyfury
run: ./ci/run_ci.sh install_pyfury
- name: Run Golang CI
run: ./ci/run_ci.sh go

lint:
name: Code Style Check
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Set up JDK ${{ matrix.java-version }}
uses: actions/setup-java@v4
with:
java-version: 21
distribution: 'oracle'
- name: Check License Header
uses: korandoru/hawkeye@v3
- name: Set up Python 3.8
uses: actions/setup-python@v5
with:
python-version: 3.8
- name: Check code style
run: ./ci/run_ci.sh format
8 changes: 4 additions & 4 deletions rust/fury/src/serializer.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -49,17 +49,17 @@ fn to_u8_slice<T>(slice: &[T]) -> &[u8] {
/// Types that implement the Serialize trait can be serialized to Fury.
///
/// 1. Normal situation:
/// The order of function calls is reserved_space -> serialize -> write.
/// The order of function calls is reserved_space -> serialize -> write.
/// a. reserved_space is used to allocate the fixed memory space, which can avoid the cost of the memory check.
/// However, dynamic types like strings should allocate the size separately before being written to the buffer.
/// b. serialize is used to serialize the data into the buffer. The first step is to write the object head,
/// which includes one byte reference flag and two byte type flag.
/// The second step is to call the write function, which is used to write the Rust object.
/// c. write is used to write the Rust object into the buffer.
/// 2. Vec situation:
/// If the object is in a Vec, the call order is reserved_space -> serialize -> write -> write_vec.
/// The write_vec function is used to write the elements of the Vec. But why can't we just loop through the elements and write each element one by one?
/// This is because Fury includes some primitive types like FuryPrimitiveBoolArray which do not include the head of the elements,
/// If the object is in a Vec, the call order is reserved_space -> serialize -> write -> write_vec.
/// The write_vec function is used to write the elements of the Vec. But why can't we just loop through the elements and write each element one by one?
/// This is because Fury includes some primitive types like FuryPrimitiveBoolArray which do not include the head of the elements,
/// but other Vecs do. So the write_vec function is necessary to handle the differences. Primitive arrays can overwrite the function.
pub trait Serialize
where
Expand Down

0 comments on commit 56a8c85

Please sign in to comment.