Skip to content

fix(schedule): correct tall view height for reservations ending befor… #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JohnVillalovos wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

fix(schedule): correct tall view height for reservations ending befor… #1146

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Web/scripts/schedule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,11 @@ function Schedule(opts, resourceGroups) {
if (opts.scheduleStyle === ScheduleTall) {
width = startTd.outerWidth() - cellAdjustment;
height = endTd.position().top - startTd.position().top;
if (calculatedAdjustment > 0 && height > 0) {
// findClosestEnd was used: endTd is the last slot STARTING before resEnd,
// but height must extend through to the bottom of that slot row
height += endTd.outerHeight();
}
Comment on lines +197 to +201
Comment on lines +197 to +201
top = startTd.position().top;
left += cellAdjustment;
}
Expand Down
Loading