Skip to content

chore(deps): bump stylelint to 17.4.0 and stylelint-config-standard t…#1156

Merged
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/lint_js_css
Mar 15, 2026
Merged

chore(deps): bump stylelint to 17.4.0 and stylelint-config-standard t…#1156
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/lint_js_css

Conversation

@JohnVillalovos
Copy link
Collaborator

@JohnVillalovos JohnVillalovos commented Mar 15, 2026

…o 40.0.0

Bump both packages together as they have a mutual peer dependency (stylelint-config-standard 40 requires stylelint >= 17).

Fix 4 new violations introduced by the upgraded rule set:

  • rgba() → rgb() (color-function-alias-notation) in 3 places
  • page-break-after → break-after (property-no-deprecated) in 1 place

Related to #1152
Related to #1154

Copilot AI review requested due to automatic review settings March 15, 2026 22:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the frontend linting toolchain by bumping Stylelint + the standard config together (to satisfy peer deps), and applies the minimal CSS changes needed to pass the newly enabled rules.

Changes:

  • Bump stylelint to 17.4.0 and stylelint-config-standard to 40.0.0.
  • Update CSS to address new lint rules (color-function-alias-notation, property-no-deprecated).
  • Regenerate package-lock.json to reflect the new dependency graph.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
package.json Updates Stylelint-related devDependencies to the new compatible versions.
package-lock.json Locks updated Stylelint + transitive dependency updates.
Web/css/schedule.print.css Replaces deprecated page-break-after with modern fragmentation property.
Web/css/schedule.css Updates color function usage to satisfy new Stylelint rule.
Web/css/librebooking.css Updates color function usage to satisfy new Stylelint rule.

You can also share your feedback on Copilot code review. Take the survey.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the frontend CSS linting toolchain by upgrading Stylelint and the standard config to versions that are mutually compatible (stylelint-config-standard@40 requires stylelint@>=17), and adjusts a few CSS declarations to satisfy newly enabled rules.

Changes:

  • Bump stylelint to ^17.4.0 and stylelint-config-standard to ^40.0.0.
  • Update CSS to comply with new rules (rgba()rgb() modern syntax; page-break-afterbreak-after).

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
package.json Updates Stylelint-related devDependencies to the new major versions.
package-lock.json Regenerates lockfile to reflect the new Stylelint dependency graph and engine constraints.
Web/css/schedule.print.css Replaces deprecated print fragmentation property with modern equivalent.
Web/css/schedule.css Updates color function usage to match upgraded Stylelint rules.
Web/css/librebooking.css Updates color function usage to match upgraded Stylelint rules.

You can also share your feedback on Copilot code review. Take the survey.

…o 40.0.0

Bump both packages together as they have a mutual peer dependency
(stylelint-config-standard 40 requires stylelint >= 17).

Fix 4 new violations introduced by the upgraded rule set:
- rgba() → rgb() (color-function-alias-notation) in 3 places
- page-break-after → break-after (property-no-deprecated) in 1 place

Related to #1152
Related to #1154
@JohnVillalovos JohnVillalovos enabled auto-merge (rebase) March 15, 2026 22:50
@JohnVillalovos JohnVillalovos merged commit 6453c9a into develop Mar 15, 2026
16 checks passed
@JohnVillalovos JohnVillalovos deleted the jlvillal/lint_js_css branch March 15, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants