fix(resource-types): load custom attribute values without entity join#1342
Merged
JohnVillalovos merged 1 commit intoLibreBooking:developfrom Apr 17, 2026
Merged
Conversation
Remove unnecessary join with custom_attribute_entities in GET_ALL_RESOURCE_TYPES so resource type custom attributes persist after page reload.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes missing/persisted display of Resource Type custom attribute values by adjusting the SQL used to load all resource types so that saved custom attribute values are returned after a page reload (Issue #1341).
Changes:
- Remove the
custom_attribute_entitiesjoin from theGET_ALL_RESOURCE_TYPESsubquery socustom_attribute_valuesare loaded solely byentity_id+attribute_category. - Minor whitespace-only SQL string formatting cleanup in a few other query constants.
JohnVillalovos
approved these changes
Apr 17, 2026
Collaborator
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
Thanks @labmecanicatec
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary join with custom_attribute_entities in GET_ALL_RESOURCE_TYPES so resource type custom attributes persist after page reload.
Closes: #1341