fix(schedule): centralize render completion and auto-scroll#1410
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes schedule render-completion logic into a single finishRender helper and moves auto-scroll-to-today into a reusable function that runs after reservations are rendered, fixing the bug where auto.scroll.today had no effect because it ran before reservations were drawn.
Changes:
- Introduces
autoScrollToToday()(guarded by a one-shothasAutoScrolledTodayflag) usingscrollIntoView. - Removes the early auto-scroll attempt in
init()that ran before reservations rendered. - Consolidates the post-render steps (initReservable, hide loader, reset flag, auto-scroll) into a
finishRender()closure used by both render branches.
Refactor schedule rendering to remove duplicated completion logic in both render branches. Introduce a single finishRender flow that: - initializes reservable interactions when enabled - hides the loading indicator - resets renderingEvents - triggers autoScrollToToday Close: LibreBooking#1409 Assisted-by: Copilot:GPT-4.1
JohnVillalovos
approved these changes
Jun 1, 2026
JohnVillalovos
left a comment
JohnVillalovos
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @labmecanicatec
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor schedule rendering to remove duplicated completion logic in both render branches. Introduce a single finishRender flow that:
Close: #1409
Assisted-by: Copilot:GPT-4.1