Only trigger CI builds on master branch and pull requests#118
Open
Only trigger CI builds on master branch and pull requests#118
Conversation
Member
|
Hm actually I prefer getting CI feedback right on the first push of a new branch, without requiring to open a PR (yet) 🙈 IMHO the redundant CI runs are not a real problem as the runs are pretty fast, i.e. not wasting much time and resources... |
Member
Author
I was just annoyed by the 8 checks showing up. If I want CI I open a PR, if it's not ready yet I mark it as draft. |
e578ddf to
c57c224
Compare
c57c224 to
5795416
Compare
If we trigger on every branch we will have redundant CI runs for branches with pull requests.
5795416 to
a4213fc
Compare
Member
Author
|
I mean CI takes less then a minute in this project. If you want feedback before opening a PR you can run the tests locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we trigger on every branch we will have redundant CI runs for branches with pull requests.