Skip to content

Upgrade openpdf to 1.4.1 and fix build#18

Merged
asturio merged 1 commit intoLibrePDF:masterfrom
fridrich:master
Aug 11, 2025
Merged

Upgrade openpdf to 1.4.1 and fix build#18
asturio merged 1 commit intoLibrePDF:masterfrom
fridrich:master

Conversation

@fridrich
Copy link
Collaborator

A little patch not to use deprecated methods from openpdf 1.3.x, which have been removed from 1.4.x. Both 1.3.36 and 1.4.1 can be used to compile with this patch, but it makes upgrade to 1.4.1 possible.

@fridrich
Copy link
Collaborator Author

Anybody is handling this one?

@andreasrosdalw
Copy link
Contributor

@asturio
Can you please add @fridrich as a maintainer to this repository? Hopefully adding a new developer to this project can help update and fix it. I have retired from OpenRTF development.

@fridrich
Copy link
Collaborator Author

I don't really need to be a developer with commit access. I would just not mind this 1+ year old PR to be handled (accepted or refused).

@andreasrosdalw
Copy link
Contributor

@fridrich Yes, thank you. As one of very few people interested in this library, I would like to encourage you to help with the maintenance. I don't have commit access any more. @asturio can help you get access.

@olivierDelierre
Copy link
Collaborator

olivierDelierre commented Aug 5, 2025

I'd rather be in favor with upgrading the dependency to OpenPDF 2.0.4 since it would also fix this issue: #15

I currently don't have the time to write another PR containing this dependency change till this week-end, but feel free if you want to update your PR accordingly.

@andreasrosdalw
Copy link
Contributor

Maybe it's time to fork this OpenRTF repo. I don't have access here. @asturio can give access, but he is busy with other things often.

@asturio
Copy link
Member

asturio commented Aug 11, 2025 via email

@asturio
Copy link
Member

asturio commented Aug 11, 2025

@fridrich Fell free to improve some parts here. Sorry, I don't look at OpenPDF to often, and even less OpenRTF.

So, I'll merge it now, but upgrading to other versions of OpenPDF would also be ok.

A new Release with this update will come this week.

@asturio asturio merged commit dbdc454 into LibrePDF:master Aug 11, 2025
@asturio
Copy link
Member

asturio commented Aug 11, 2025

@olivierDelierre

Please let me know if you also like to help maintaining this project.

@olivierDelierre
Copy link
Collaborator

@olivierDelierre

Please let me know if you also like to help maintaining this project.

Hey @asturio. Feel free to put me as maintainer. Not sure how much time I'd have for it, but I guess it does not hurt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants