Fix/6855 replace deprecated iconfig methods#6999
Merged
vitormattos merged 5 commits intoLibreSign:mainfrom Feb 26, 2026
Merged
Conversation
|
Thanks for opening your first pull request in this repository! ✌️ |
vitormattos
requested changes
Feb 26, 2026
Member
vitormattos
left a comment
There was a problem hiding this comment.
Look the CI, wasn't happy:
https://github.com/LibreSign/libresign/actions/runs/22426348763/job/65017841175?pr=6999
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
64080fd to
a2a5e04
Compare
Contributor
Author
|
Fixed, ran the |
Member
|
/backport to stable33 |
|
The backport to # Switch to the target branch and update it
git checkout stable33
git pull origin stable33
# Create the new backport branch
git checkout -b backport/6999/stable33
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 54f8693c 4aebb374 485ca2b9 10b8b454 a2a5e046
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6999/stable33Error: Failed to push branch backport/6999/stable33: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
|
/backport to stable33 |
Member
|
/backport to stable32 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR replaces deprecated
\OCP\IConfigusage.Files changed
lib/Service/AccountService.phplib/Migration/Version12000Date20250517134200.phplib/Controller/AccountController.phptests/php/Unit/Service/AccountServiceTest.phpTests results:
composer test:unit -- --filter AccountService -> OK (25 tests, 50 assertions)composer test:unit -- --filter AccountController -> OK (3 tests, 4 assertions)Related Issue
Issue Number: #6855
Pull Request Type