Skip to content

Fix/6855 replace deprecated iconfig methods#6999

Merged
vitormattos merged 5 commits intoLibreSign:mainfrom
lfals:fix/6855-replace-deprecated-iconfig-methods
Feb 26, 2026
Merged

Fix/6855 replace deprecated iconfig methods#6999
vitormattos merged 5 commits intoLibreSign:mainfrom
lfals:fix/6855-replace-deprecated-iconfig-methods

Conversation

@lfals
Copy link
Copy Markdown
Contributor

@lfals lfals commented Feb 26, 2026

Pull Request Description

This PR replaces deprecated \OCP\IConfig usage.

Files changed

  • lib/Service/AccountService.php
  • lib/Migration/Version12000Date20250517134200.php
  • lib/Controller/AccountController.php
  • tests/php/Unit/Service/AccountServiceTest.php

    Tests results:

composer test:unit -- --filter AccountService -> OK (25 tests, 50 assertions)
composer test:unit -- --filter AccountController -> OK (3 tests, 4 assertions)

Related Issue

Issue Number: #6855

Pull Request Type

  • Refactoring (no functional changes, no api changes)

@github-project-automation github-project-automation Bot moved this to 0. Needs triage in Roadmap Feb 26, 2026
@welcome
Copy link
Copy Markdown

welcome Bot commented Feb 26, 2026

Thanks for opening your first pull request in this repository! ✌️

@lfals lfals marked this pull request as ready for review February 26, 2026 03:52
Copy link
Copy Markdown
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-project-automation github-project-automation Bot moved this from 0. Needs triage to 1. to do in Roadmap Feb 26, 2026
@lfals lfals requested a review from vitormattos February 26, 2026 17:05
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
Signed-off-by: Luis Amorim <luisfelipeamorim@hotmail.com>
@lfals lfals force-pushed the fix/6855-replace-deprecated-iconfig-methods branch from 64080fd to a2a5e04 Compare February 26, 2026 17:06
@lfals
Copy link
Copy Markdown
Contributor Author

lfals commented Feb 26, 2026

Fixed, ran the composer run cs:fix command as requested from the ci

@vitormattos
Copy link
Copy Markdown
Member

/backport to stable33

Copy link
Copy Markdown
Member

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@vitormattos vitormattos merged commit 5133448 into LibreSign:main Feb 26, 2026
65 of 68 checks passed
@github-project-automation github-project-automation Bot moved this from 1. to do to 4. to release in Roadmap Feb 26, 2026
@backportbot-libresign
Copy link
Copy Markdown

The backport to stable33 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable33
git pull origin stable33

# Create the new backport branch
git checkout -b backport/6999/stable33

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 54f8693c 4aebb374 485ca2b9 10b8b454 a2a5e046

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/6999/stable33

Error: Failed to push branch backport/6999/stable33: fatal: could not read Username for 'https://github.com': No such device or address


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@vitormattos
Copy link
Copy Markdown
Member

/backport to stable33

@vitormattos
Copy link
Copy Markdown
Member

/backport to stable32

@lfals lfals deleted the fix/6855-replace-deprecated-iconfig-methods branch March 31, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants