feature: Support iCloud Keychain #52
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code change adds support for
kSecAttrSynchronizable, which is iCloud Keychain syncing.I'm not sure if you want to treat this the same way you've handled
kSecAttrAccessGroupor if there's another design you had in mind. The reason I call this out is becausekSecAttrAynchronizableallows for three values when querying: true (kCFBooleanTrue), false (kCFBooleanFalse), andkSecAttrSynchronizableAny(meaning "either").Supporting iCloud Keychain in KVault helps my migration from a fully native iOS app to KMM. Furthermore, iCloud Keychain is a nice end user feature that preserves keychain items as users upgrade devices or pick up multiple devices.