Return none not object array #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had been returning a np.array of None values, which MatFlow wasn't able to serialise.
Python 3.8 gave errors trying to install some of the dependencies
3.13 gave an error that it wasn't supported by the project.
Ubuntu tests were failing - everything else passed.
Collaborator
Author
|
@aplowman |
Collaborator
Author
|
@dkfellows Any ideas on how to get the final macos test of the os matrix running? |
…happen in the unrealistically small examples in the tests)
Contributor
|
Hopefully the above commit has done the trick. |
This comment has been minimized.
This comment has been minimized.
Collaborator
Author
|
Great, thanks! But now it looks like the tests passed before you made that change (I'm sure they didn't) 🤷 |
aplowman
approved these changes
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When seeds are not user-defined and take the default value of None, don't convert that into an object array of "None"s.
Fixes the issue described here: hpcflow/matflow#432 (comment)