Expand Centrallix-lib Tests #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improve edge case logic in comparison functions. Remove unregister driver function. Clean up exp_functions.c.
Simplify dataqa_duplicates component in preparation for making it the boundary into our new duplicate system. Add exp functions: sparse_eql(), ln(), and logn(). Fix bugs in comparison functions. Make minor tweaks to objdrv_cluster.c.
Modify cluster files to use string keys. Build vectors fully sparsely. Add ca_fprint_vector(). Add snprint_llu(). Add exp_fn_trim(). Update exp_fn_cmp(). Organize exp function definitions by group. Add statistics tracking to cluster driver. Reduce minimum hint threshold. Add array handling to ci_xaToTrimmedArray(). Update timer to handle multiple starts and stops properly.
Re-add Levenshtein to exp_functions. Publish edit_dist() in the cluster library. Fix mistakes in cluster driver function signatures. Fix spelling mistakes. Add detail to an error message in the lexer. Remove unused .cluster files. Clean up cluster-schema.cluster. Clean up other unused junk.
Add known issues to string similarity documentation. Clean up and organize todos. Clean up testing code in several files.
…ast commit). Update tests to pass with this modification.
… caches). Fix a formatting issue with the stat method. Fix a missing include in the util.c library.
…le hundred bytes. Add check_double() to handle functions that return NAN on failure. Clean up.
…rary. Round similarity results to avoid floating point errors. Enable caching for memory allocated in get_cluster_size(). Rename edit_dist() to ca_edit_dist() to match format for public functions. Rename print_diagnostics() to print_err().
Fix a possible uninitialized read. Fix memset() not initializing data.
Improve documentation.
Add test_utils.h to make tests cleaner to read and write. Make UTIL_USE_METRIC in util public. Add tests for util. Add tests for xarray. Add tests for xstring. Fix undefined behavior in xstring. Fix a typo in test_util_00.c.
Contributor
Author
|
This PR partially addresses #28. |
Contributor
Author
|
Got it, everything has tests except for the k-means algorithm. That's definitely the hardest to test. |
Fix edge case: Tests taking longer than 1 second (centrallix-lib test driver). Expand test_utils.h. Handle missing edge cases in clusters.c. Fix memstr_00 test.
Contributor
Author
|
That should handle most of the functionality in Everything is tested except for the k-means algorithm. |
Fix missing edge cases in clusters.h.
Contributor
Author
|
I need to do another code review on this branch before Greg reviews it. |
Add tests for nmMalloc(). Add EXPECT_NOT_NULL() to test_utils.h. Modify test runner to use 5s timeout normally, but 90s timeout in Valgrind. Improve documentation, style, and formatting.
Lightning11wins
force-pushed
the
centrallix-lib-tests
branch
from
4d8e990 to
35dbb58
Compare
Contributor
Author
|
Styling issues are now corrected; this branch should be ready for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional testing for the
newmalloc,util,xarray,xstring, andclusterslibraries.Add
test_utils.hto make tests cleaner to read and write.Fix a couple of minor bugs in libraries.