NewMalloc improvements #82
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isabled. Abstract registered block name printing into a public helper function. Optimize nmSysRealloc() to do nothing when asked to reallocate memory to the current size.
Contributor
Author
|
This PR will close #81: confusing code in newmalloc.c. |
Contributor
Author
|
The styling on here is wrong. I'll need to rewrite it at some point. |
Contributor
Author
|
This PR was reworked in #83. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the developer experience when using the NewMalloc system by using a cleaner code structure with comments to enable faster speed-reading. This new code intends to make it easy for readers to quickly skim code so that they can find what they're looking for without getting lost in code for irrelevant features that might not even be enabled in their environment.
This branch also introduces a couple of minor logical changes and optimizations in the final commit, mostly intended to improve the developer experience.
I recommend that Greg take ownership of the first commit so that we can avoid having me get git blamed for reformatting most of the file with very minimal changes to any of the logic.