9회차과제 - 김주희 #8
Open
9회차과제 - 김주희 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyw2790
reviewed
May 28, 2024
There was a problem hiding this comment.
svg 파일을 사용할때 publice에 정리하는 것이 컴포넌트를 더 깔끔하게 보일 것 같습니다. import { ReactComponent as MyIcon } from './icons/my-icon.svg'; 이런식으로 하면 될거같습니다!
There was a problem hiding this comment.
오! 좋은 방법인 것 같습니다~ 참고하겠습니다!
리뷰 감사합니다:)
kyw2790
reviewed
May 28, 2024
| <Route path="/about" element={<About/>}/> | ||
| <Route path="/techService" element={<TechService/>}/> | ||
| <Route path="/notice" element={<Notice/>}/> | ||
| <Route path="*" element={<NotFound/>}/> |
There was a problem hiding this comment.
<Route path="*" element={}/> 사용하여서 error 페이지 만든 것이 인상깊네요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
내가 개발한 기능
유의 깊게 개발한 부분
개발할 때 들었던 의문사항