6회차 과제 - 구준혁 #5
Open
6회차 과제 - 구준혁 #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
kyw2790
reviewed
May 8, 2024
| import ShortBox from './ShortBox'; | ||
|
|
||
| const Short = () => { | ||
| const shortList = [ |
There was a problem hiding this comment.
배열을 통해서 id 필드 추가하니 다양한 값을 넣을 수 있고 코드도 깔끔하게 보이네요!!
| </Box> | ||
| ); | ||
| }; | ||
| const Box = styled.div` |
There was a problem hiding this comment.
styled-components 를 사용해서 구현해보았습니다! className을 통한 다른 css파일에서의 접근보다는 더 직관적인것 같아 괜찮은것 같습니다!
|
@YoonKeumJae 코드 리뷰 완료했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 구조 설계
App
Header
Video
Menu_li
VideoBox
Short
ShortBox
2. 실행 결과 화면
3. 아쉬웠던 점
4. 새롭게 알게된 점