Feat/nextjs app router integration #124
Conversation
|
@meet-bhimani Thanks for the PR! I'd have to preface by saying it's going to be quite a lot of changes to get this PR merge. Before reviewing, the dev/nextjs-app-router folder has to be deleted and changes have to be applied to dev/next-app-project. The functions in the api folder should be merge into the lib/server folder that the rest of the API code lives. This is necessary to move the PR forward. More comments for now:
|
|
Hi Andreas,
Thank you for your suggestions! I wanted to let you know that we are
currently in the midst of festival season here in India, so I may not be
able to make the changes right away. However, I will definitely look into
them in a few days. In the meantime, any steps you could take would be
greatly appreciated.
Additionally, I’d like to ask for your help. I’m interested in using this
repository's code as a personal npm package. Could you please guide me on
how to do this?
Thank you for your understanding!
<https://www.bacancytechnology.com/>
*Meet Bhimani*
Junior Software Engineer (ReactJS)
***@***.*** ***@***.***>*
<https://www.facebook.com/BacancyTechnologyLimited>
<https://www.linkedin.com/company/bacancy-technology>
<https://dribbble.com/bacancytechnology> <https://twitter.com/BacancyTech>
<https://www.youtube.com/channel/UCsfzvYIiaW011xS1GCKHJhw>
<https://www.instagram.com/bacancytechnology/>
…On Wed, Oct 30, 2024 at 6:29 PM Andreas Tzionis ***@***.***> wrote:
@meet-bhimani <https://github.com/meet-bhimani> Thanks for the PR!
I'd have to preface by saying it's going to be quite a lot of changes to
get this PR merge.
Before reviewing, the dev/nextjs-app-router
<https://github.com/meet-bhimani/destack/tree/feat/nextjs-app-router-integration/dev/nextjs-app-project>
folder has to be deleted and changes have to be applied to
dev/next-app-project
<https://github.com/LiveDuo/destack/tree/main/dev/nextjs-app-project>.
The functions in the api folder should be merge into the lib/server
<https://github.com/LiveDuo/destack/tree/main/lib/server> folder that the
rest of the API code lives. *This is necessary to move the PR forward.*
More comments for now:
- type any should be replaced with the appropriate types
- try / catch blocks should be removed as they create silent errors.
this repo follows the Let it crash <https://wiki.c2.com/?LetItCrash>
philosophy from erlang for the various reasons described in the blog post
- almost all comments are better removed, hard to better explain than
this CodeAesthetic video <https://www.youtube.com/watch?v=Bf7vDBBOBUA>
—
Reply to this email directly, view it on GitHub
<#124 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BG7SAKHYEHZGYV5POGRG4J3Z6DJ2JAVCNFSM6AAAAABQ3WBAI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBXGA3DOMJYGI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@meet-bhimani That's fine, there's no rush. There's the |
|
I got your point, if possible can you please help me to publish that
version of the code which I have created PR for, as I want to use it in my
nextjs app router project.
Even if you can publish it as private package then also it's fine for me
Looking forward to hear from you
Thanks,
…On Thu, 31 Oct 2024, 2:39 pm Andreas Tzionis, ***@***.***> wrote:
@meet-bhimani <https://github.com/meet-bhimani> That's fine, there's no
rush.
There's the npm publish command that publishes to npm (it builds the
project automatically using the prepublishOnly script
<https://github.com/LiveDuo/destack/blob/main/lib/package.json#L25>).
That been said, since the structure of the API folder is changed things
might not work as expected.
—
Reply to this email directly, view it on GitHub
<#124 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/BG7SAKDQWI5XFNZJNIXWVUTZ6HXWFAVCNFSM6AAAAABQ3WBAI6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINBZGM3TOMZVGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
I don't think it's a good idea to publish the package for you for multiple reasons. The publish command is not that hard either to publish it yourself. |
|
Okay, I understand your point. I really appreciate if you could help me to
give the steps for publishing including which folders to include and which
directory needs to be published. Thanks in advance.
|
|
You can the all folders that needs to be published in npm https://www.npmjs.com/package/destack?activeTab=code. |
|
Thanks, I'll check them out.
|
|
What are the chances of getting this merged? |
As is, it's not ready to be merged. At the current state it's not ready to be code reviewed either as the work is not done in the right place (see #124 (comment) for more info). If the PR it's updated to reflect the structure of the project I'd review it and leave proper feedback. It's been a while though and I wouldn't have high hopes OP is still interested in moving this forward |
I am not able to revisit the code again and do workaround due to some other stuff. if you have any urgent need then you can checkout this upgraded version of this here |
This pull request integrates support for the Next.js app router (Next.js 14) into the project, significantly improving compatibility and functionality.
For a comprehensive overview of the changes, including detailed integration steps and code snippets, please refer to the NEXTJS_APP_ROUTER_INTEGRATION.md file or check here
feel free to contact me for any discussions