Feature/import map support #1704
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merryman
force-pushed
the
feature/import-map-support
branch
from
c6bdfcc to
c0b3586
Compare
Previously some weirdly formatted es modules from esm servers would not be categorized correctly.
Issue that happens if a local variable in a module has the same name as its exported alias, which the transformed code previously would cause to be overridden. This only works with the babel transform for now.
merryman
force-pushed
the
feature/import-map-support
branch
from
c0b3586 to
565638b
Compare
Previously would return the wrong expression for export {} statements that were directly adjacent to another object expression.
Previously we would consider if/else blocks to be of the same scope as the aprent, leading to incorrect transformations in case of let and const statements.
merryman
force-pushed
the
feature/import-map-support
branch
from
565638b to
5d954c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for defining dependencies via import maps which is crucial to move away from
jspm.dev.Also is crucial for the import-map support, since a variety of babel related modules needed for that are currently broken on
jspm.devand wont be fixed anymore.