Enhancement/chai upgrade #1711
Draft
Enhancement/chai upgrade #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge the var and ref replacement and the import export traversal into single passes.
The key is here to make the node functions parametrized, so that depending on the underlying AST system different nodes can be created by the same transform.
Was needed due to to the changes in the class transform that preserves the class name as a binding during class initialization.
Since babel.js has a bunch of circular imports it has weird importing specific code that checks if modules have been already initialized. We introduce a method called bulletProofNamespace() which helps us to adjust these error checking codes such that they work in split bundles.
The transpiler initialization needed to be adjusted.
Due to the upgrade in chai, we no longer have the chai subset convenience methods, so these need to be added by a custom 3rd party package.
This is nessecary due to the chai upgrade.
Due to upgrding chai, the comparison function that compares structs did not work any more since it started to compare prototypes as well. Wrapping the compared objects in JSON.parse/stringify seems to solve the issue.
merryman
force-pushed
the
enhancement/chai-upgrade
branch
from
180c15a to
3fa270a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be merged as soon as #1710 has been merged.