Skip to content

Code Clean up #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from
Closed

Code Clean up #257

wants to merge 11 commits into from

Conversation

vish288
Copy link

@vish288 vish288 commented Sep 8, 2017

Indentation consistency
Removal of Lint issues.
Es6 literal usage.

@codecov-io
Copy link

codecov-io commented Sep 8, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@539dab5). Click here to learn what that means.
The diff coverage is 90.47%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #257   +/-   ##
=========================================
  Coverage          ?   82.55%           
=========================================
  Files             ?        5           
  Lines             ?      149           
  Branches          ?        0           
=========================================
  Hits              ?      123           
  Misses            ?       26           
  Partials          ?        0
Impacted Files Coverage Δ
src/defaults.js 75% <ø> (ø)
src/diff.js 100% <100%> (ø)
src/helpers.js 100% <100%> (ø)
src/index.js 87.09% <85%> (ø)
src/core.js 73.33% <92.85%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 539dab5...5512b6d. Read the comment docs.

# Conflicts:
#	src/index.js
@vish288
Copy link
Author

vish288 commented Sep 8, 2017

updated the code to include the commit from https://github.com/mfeniseycopes/redux-logger/tree/refactor as well. #223

@vish288
Copy link
Author

vish288 commented Sep 17, 2017

@evgenyrodionov : The issue seems to be with codecov.io not having a comparison.
Apart from that could you comment on the code pls?

Visweshwaran Suryanarayanan added 4 commits August 6, 2019 11:49
1. Update dependencies to the latest version.
2. Upgrade babel
3. Upgrade eslint
4. Upgrade Rollup
5. Cleanup rollup config.
6. Introduce Terser instead of Uglify
@vish288 vish288 closed this Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants