Skip to content

feat: add DanaKit #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

feat: add DanaKit #247

wants to merge 1 commit into from

Conversation

bastiaanv
Copy link

@bastiaanv bastiaanv commented Apr 21, 2025 •
edited
Loading

After quite some development time and several fixes, I believe DanaKit is ready to merge to Loop!

ping @marionbarker

@marionbarker
Copy link
Contributor

I will test this again @bastiaanv
My recommendation is that we wait until after Loop 3.6.0 is released and then discuss adding this to dev for evaluation.

@marionbarker
Copy link
Contributor

Successful test on 26 April 2025:

  • I started with LoopWorkspace main branch, which is currently at the same level as the dev branch
  • I confirmed I was using DanaKit SHA: f870821
  • I tested using the DanaKit simulator

Comment:

  • This same repository is used by testers of the Trio app (they point to loopandlearn/DanaKit dev branch directly)
  • A "copied" version of this repository is incorporated into the iAPS code base and provided to users of the iAPS app
  • @bastiaanv has been accepting input from all sources to improve his repository

@marionbarker marionbarker requested a review from ps2 April 27, 2025 17:09
marionbarker
marionbarker approved these changes Apr 27, 2025
View reviewed changes
Copy link
Contributor

@marionbarker marionbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve from code review and test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marionbarker marionbarker marionbarker approved these changes

@ps2 ps2 Awaiting requested review from ps2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bastiaanv @marionbarker