Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Analogous to https://github.com/ankicommunity/anki-devops-services/blob/2218ed5f857c42085fd7091ea36f5b7c73f2ffae/services/anki-sync-server/images/Dockerfile#L35
Doing
VOLUME
here does not really prevent docker-compose from overriding it. This is similar to howEXPOSE
does not really matter for docker-compose'sports
. But at least there will always be a volume by default, lowering chances of misconfiguring the thing and losing the data together with the container.The only doubt I have that
SYNC_BASE
here isENV
and notARG
. Maybe it would make more sense to switch it toARG
. I personally can't really see a use-case for being able to overwrite the sync path inside the container anyways. If one wants to do something different with it, they should probably just mount a volume on top of the hardcoded path.