WIP: grating compression #364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
LGTM, just a minor docstring error. is this still WIP really? |
Contributor
Author
|
Yes, in that I haven't tested much, or added tests! |
Collaborator
|
sorry, to clarify--is that still actually in progress, ie are you likely to have time to do it? |
Contributor
Author
|
Oh, I see! Yes, I plan to do it, when I get time... Tests are not totally trivial, because this includes the full phase, so cannot be directly compared to analytic formulas. So my plan was to manually build an example that I have manually checked and use that as a test basis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
prop_gratingsto simply model a grating compressor.