Skip to content

Conversation

@emileten
Copy link
Contributor

Continued your work @smk0033 ! 😃 Mostly adding screens, that take in account these changes MAAP-Project/Community#810.

Note : this PR will go to your branch

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@emileten emileten requested a review from smk0033 September 27, 2023 02:49
{
"cells": [
{
"cell_type": "markdown",
Copy link
Contributor Author

@emileten emileten Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this form is to provide a way for users to request data to be ingested into the MAAP STAC Catalog for use.

A question because it's still not 100% clear to me. Is this form encompassing both requests for (1) data storage (having the data in the MAAP S3 bucket) and (2) MAAP STAC metadata storage ? I was under the impression that no, this form is just for (1) and we want another one for (2).

If we want these processes to happen together though, we could use only this form, but maybe it has to be enriched (we can do that later) with information we will need to create the metadata.


Reply via ReviewNB

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh yeah, I didn't think about S3, my mind automatically went to STAC for some reason. I'll wait for Alex to answer on that one

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This form is for "official" import to MAAP, aka STAC which implies it's already on S3 or a copy will be placed there.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, eventually we'll need more info from users. This was step one. You can see what details to add is still being debated MAAP-Project/Community#712

@smk0033
Copy link
Contributor

smk0033 commented Sep 27, 2023

Thanks Emile, the updates look great!

@smk0033 smk0033 merged commit 095d0b8 into newdata-form-sk Sep 27, 2023
@smk0033 smk0033 deleted the improve-newdata-form-sk branch September 27, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants