-
Notifications
You must be signed in to change notification settings - Fork 100
Write out T2* & S0 variance + T2*-S0 covariance #1290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Before I fix up all of the unit tests, I want to verify that we (1) want this and (2) like the configuration I've set up. The new variance/covariance files are only generated if I could also create figures for them as well, if that would be useful. |
1. Estimate t2s_full and s0_full, but not t2s_limited and s0_limited, in fit_decay/fit_decay_ts. 2. Create new function to create the limited maps from the full maps and apply the ceilings and floors. 3. Use masked arrays in fit_decay/fit_decay_ts instead of masking internally. 4. Delete more variables when we're done using them to hopefully free up memory.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1290 +/- ##
==========================================
- Coverage 89.70% 89.70% -0.01%
==========================================
Files 29 29
Lines 4441 4489 +48
Branches 740 744 +4
==========================================
+ Hits 3984 4027 +43
- Misses 302 305 +3
- Partials 155 157 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Why do you have squares on the brain on some of the slices? |
|
I don't know. They're very odd. I was thinking maybe they might be related to EPI high variance lines based on this video @handwerkerd sent me before the holidays: https://youtu.be/rl9vYLbCq34?si=NzTkyFExy_wLrY8_&t=950. EDIT: Never mind. I looked at them with fsleyes and they look fine, so I think it's just a bug in |
|
These look great! |






Closes #1268.
Changes proposed in this pull request:
--fittype curvefitand--verbose.