Skip to content

Conversation

@tsalo
Copy link
Member

@tsalo tsalo commented Jan 8, 2026

Closes #1295.

Changes proposed in this pull request:

  • Make tag check in minimum_image_regression robust to letter case.
  • Use the component plot structure for GSR and MIR plots.

@tsalo tsalo added the reports issues related to boilerplate generation or visual reports label Jan 8, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 89.69%. Comparing base (9bf1335) to head (ce06637).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
tedana/gscontrol.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1298   +/-   ##
=======================================
  Coverage   89.69%   89.69%           
=======================================
  Files          29       29           
  Lines        4530     4513   -17     
  Branches      751      749    -2     
=======================================
- Hits         4063     4048   -15     
  Misses        316      316           
+ Partials      151      149    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tsalo added 3 commits January 8, 2026 14:03
This addresses a mismatch between the tags in the MIR code (including "low variance") and the ones in the minimal decision tree ("Low variance").
@tsalo
Copy link
Member Author

tsalo commented Jan 8, 2026

Here are examples of the new plots

Screenshot 2026-01-08 at 3 25 44 PM Screenshot 2026-01-08 at 3 25 42 PM

I think they look pretty good!

@tsalo tsalo marked this pull request as ready for review January 8, 2026 20:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Member

@handwerkerd handwerkerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tsalo tsalo merged commit 674abd8 into ME-ICA:main Jan 14, 2026
34 checks passed
@tsalo tsalo deleted the gscontrol-plots branch January 14, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

reports issues related to boilerplate generation or visual reports

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reformat gscontrol plots into component-like plots

2 participants