custom colors overhaul #786
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's not needed
(minor) cleanup warnings in binary
This reverts commit 68b86a0.
(minor) clean up some warnings in astero, eos, kappa, num (unused var, int division)
(minor) fix some compiler warnings in rate, adding some onlys in star
fix uninitialized memory in net_burn_const_p.f90
nialljmiller
force-pushed
the
features/nialljmiller/customcolors
branch
from
a3c089b to
e4db021
Compare
nialljmiller
requested review from
annethoul,
aurimontem,
evbauer,
mjoyceGR,
orlox and
rsmolec
as code owners
Member
|
If you can resolve the merge conflicts and merge main into this branch, it might squash most of the file changes being flagged in this pr. As is, it's just too messy to code review. It's not clear which files are being modified because there are 5000+ file changes atm. Once squashed, I can do a code review and help solve whatever is crashing the rsp/gyre tests. |
4 tasks
Member
|
This is moved over to a new / clean PR: #841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.